Skip to content

GH-108614: Increase importlib MAGIC for RESUME_CHECK instruction#109247

Merged
vstinner merged 1 commit intopython:mainfrom
vstinner:resume_check_importlib_magic
Sep 11, 2023
Merged

GH-108614: Increase importlib MAGIC for RESUME_CHECK instruction#109247
vstinner merged 1 commit intopython:mainfrom
vstinner:resume_check_importlib_magic

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Sep 11, 2023 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request Sep 11, 2023
Closed
@vstinner vstinner mentioned this pull request Sep 11, 2023
Closed
@vstinner vstinner merged commit 3b2ecbc into python:main Sep 11, 2023
@vstinner vstinner deleted the resume_check_importlib_magic branch September 11, 2023 07:34
@bedevere-bot
Copy link

bedevere-bot commented Sep 11, 2023

There's a new commit after the PR has been approved.

@iritkatriel: please review the changes made to this pull request.

@vstinner
Copy link
Member Author

vstinner commented Sep 11, 2023

Thanks for the review @iritkatriel.

@bedevere-bot
Copy link

bedevere-bot commented Sep 11, 2023

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM64 macOS 3.x has failed when building commit 3b2ecbc.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/725/builds/5597) and take a look at the build logs.
  4. Check if the failure is related to this commit (3b2ecbc) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/725/builds/5597

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "<frozen importlib._bootstrap>", line 1354, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1325, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 929, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 1001, in exec_module
  File "<frozen importlib._bootstrap_external>", line 1097, in get_code
  File "<frozen importlib._bootstrap_external>", line 1196, in get_data
TypeError: descriptor 'close' for '_io.BufferedReader' objects doesn't apply to a '_io.FileIO' object


Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/threading.py", line 1059, in _bootstrap_inner
    self.run()
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/threading.py", line 996, in run
    self._target(*self._args, **self._kwargs)
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_interpreters.py", line 483, in task
    interp = interpreters.create()
             ^^^^^^^^^^^^^^^^^^^^^
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/support/interpreters.py", line 25, in create
    id = _interpreters.create(isolated=isolated)
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
RuntimeError: interpreter creation failed
k

@markshannon
Copy link
Member

markshannon commented Sep 11, 2023

Thanks @vstinner

@vstinner
Copy link
Member Author

vstinner commented Sep 11, 2023

It's unfortunate that we have to increase this number during development even before the first alpha version, but well, as shown in the issue, practicability beats purity here 😁 Apparently people still like PYC during alpha releases 😁

Or maybe we could not write PYC nor use them before first beta version? I don't know. For now, the status quo is to update the MAGIC number.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner

@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

@iritkatriel iritkatriel Awaiting requested review from iritkatriel

Assignees

No one assigned

Labels

awaiting core review skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vstinner @bedevere-bot @markshannon @iritkatriel